TASK: Provide alternative for NodeDiscriminator::fromNode that doesnt use Nodes content stream
#5144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
12 tasks
We cannot rely on $this->currentContentStreamId being the matching one for $this->currentNode, because the step
`I expect a node identified by live-cs-identifier;lady-eleonode-nodesworth;{} to exist in the content graph`
can initialize a foreign node!
|
Okay so i tried 3 different ways of achieving the goal (not to use $node->subgraphIdentity->contentStreamId) and im now kinda happy with the last attempt of introducing a Horray 🥳 |
mhsdesign
force-pushed
the
task/dontUseNodesContentStreamIdInNodeDiscriminator
branch
2 times, most recently
from
0d3bc77 to
6101daf
Compare
…`ContentStreamAwareNode`
mhsdesign
force-pushed
the
task/dontUseNodesContentStreamIdInNodeDiscriminator
branch
from
6101daf to
eef4166
Compare
mhsdesign
commented
Jun 19, 2024
Comment on lines
+16
to
+17
| /** Alias for $currentNode->instance->aggregateId */ | ||
| public NodeAggregateId $aggregateId, |
There was a problem hiding this comment.
that way we dont need to rewrite too much code ...
| $subgraph = $this->getCurrentSubgraph(); | ||
|
|
||
| $parent = $subgraph->findParentNode($currentNode->aggregateId); | ||
| Assert::assertInstanceOf(Node::class, $parent, 'Parent not found.'); | ||
| $actualParentDiscriminator = NodeDiscriminator::fromNode($parent); | ||
| $actualParentDiscriminator = NodeDiscriminator::fromNode($currentNode->builder()->buildNode($parent)); |
There was a problem hiding this comment.
alternative: ... if we dislike the god object
Suggested change
| $actualParentDiscriminator = NodeDiscriminator::fromNode($currentNode->builder()->buildNode($parent)); | |
| $actualParentDiscriminator = NodeDiscriminator::fromNode(ContentStreamAwareNodeBuilder::fromNode($currentNode)->buildNode($parent)); |
bwaidelich
reviewed
Jun 28, 2024
There was a problem hiding this comment.
We agreed not to have this kind of DTOs today (see #5034 (comment))
|
Closing in favour of #5169 |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #5034 and #5043
Upgrade instructions
Review instructions
Checklist
FEATURE|TASK|BUGFIX!!!and have upgrade-instructions